New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
option to put sidebar on the right #1282
Comments
+1 for this. |
I think this is a feature best targeted for v5 and discussed in that context. There's more to consider than just making the menu appear on the right:
These are just off the top of my head. I'm sure there are more. More importantly, not every preference needs to be a core docsify feature. Is this feature useful? Possibly, but given the fact that it has never before been requested in the nearly four years that docsify has existed, I think it's safe to say that this is not a high priority feature. I'd look to our existing issues list and feature requests to get a better idea of where we should be focused. The good news is that folks that want a sidebar on the right can do so today by adding a custom |
Hi @trusktr , I am really interested in having a right-side Sidebar as well - would you please be so kind to share the exact CSS items needing to be changed re: Thanks so much! |
It's been a while since I've been here. I will circle back soon.
I think it can be a non-breaking change adding an option.
I would love if a new Docsify (v5 or v6?) Would allow people to specify
overall templates in the form of custom elements, and Docsify would ship
with a default template with its own options, and each 3rd-party template
could have it's own options.
#!/JoePea
…On Sat, Mar 27, 2021, 6:02 PM Paul Hibbitts ***@***.***> wrote:
Hi @trusktr <https://github.com/trusktr> , I am really interested in
having a right-side Sidebar as well - would you please be so kind to share
the exact CSS items needing to be changed re: modify 3 numbers in the CSS?
If you could point me in the direction of changes for the menu icon that
would be double-awesome
|
@paulhibbitts See these lines: docsify/src/themes/basic/_layout.styl Line 209 in c2cf163
(try changing docsify/src/themes/basic/_layout.styl Line 423 in c2cf163
(Similar, position from the docsify/src/themes/basic/_layout.styl Line 443 in c2cf163
(Possibly negate a number if it moves the wrong direction) That's about it! Oh, and the sidebar hamburger button needs to be repositioned to the right as well. Adding an option could simply set, for example, a CSS var to tell the styling to use left or right in a non-breaking way. |
Sidenote, a Docsify user can override those values in their own CSS. They're sort of like options in a sense. |
Thanks so much @trusktr for the very helpful info! I will give this a go. Also appreciate the tip re: changing these values in custom CSS as that would even be better for my situation etc. I too would love to see this as an option in v5 |
Hi @trusktr , thanks to your help I've got a right-side Sidebar partially working! Here is my custom CSS so far (for others interested in this via CSS):
My CSS skills are minimal, but I've tried to review your draft PR for other needed changes re: sidebar toggle , Navbar display, and the sidebar not visible at first but I've not been able to yet overcome those issues. Might you please be able to point/help me with those when convenient for you? I will be sure to share back your suggestions so others can also use this approach etc. Thanks very much, |
Feature request
An option to put the sidebar on the right instead of the left
What problem does this feature solve?
Sometimes people want it on the other side (maybe they embed Docsify somewhere that already has a sidebar on the left, or maybe they have a custom landing page with a custom menu on the right and when they click the link to go to documentation they'd also want the docs to have the sidebar on the same side).
What does the proposed API look like?
or
How should this be implemented in your opinion?
I think we might be able to achieve this just with CSS, leaving the markup alone.
cc @jhildenbiddle for CSS expertise here.
Are you willing to work on this yourself?
Of course (if/when I get the time)!
The text was updated successfully, but these errors were encountered: