[Console] Fix missing negative variation of negatable options in shell completion #46386
Conversation
carsonbot
changed the title
GromNaN
force-pushed
the
complete-negatable
branch
4 times, most recently
from
1d7cdd1
to
273c505
Compare
|
appveyor error not related to this PR: |
|
That's a new feature, so 6.2. |
|
Well, to me, that's a bugfix of the completion of option names |
|
I agree it's a bugfix. |
|
No, it's not. Even the description is clear about that: "Add negation of negatable options". Adding something is not a bug fix (or at least, not anymore). |
|
Well, the same description could be written as "ensure that all option names are completable for negatable options" |
|
Yea, I thought the same when reading the description. My reasoning is that completion should seamlessly handle any kind of option, otherwise it's buggy. |
|
Shell completion is a form of documentation of the available options. Not suggesting the negative form |
GromNaN
changed the title
|
I think the tester should be fixed also. |
This PR was squashed before being merged into the 6.1 branch. Discussion ---------- [Console] Complete negatable options (Fish) | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a Same as #46386 for Fish (introduced in 6.1). Commits ------- 02b7b52 [Console] Complete negatable options (Fish)
|
Thank you @GromNaN. |
Add negation of negatable options in bash completion output.
2nd PR for Fish, targeting branch 6.1: #46387