New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpClient] Allow yielding Exception from MockResponse's $body to mock transport errors #44568

Merged

fancyweb merged 1 commit into symfony:6.1 from fancyweb:http-client/mock-response-exception

Dec 18, 2021

Contributor

fancyweb commented Dec 11, 2021

Q	A
Branch?	6.1
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

A minor DX feature to allow simulating error chunks more easily (instead of being forced to throw from a \Generator).

carsonbot added Status: Needs Review Feature HttpClient labels

carsonbot added this to the 6.1 milestone

fancyweb force-pushed the http-client/mock-response-exception branch 2 times, most recently from a7092dd to 13d234c

nicolas-grekas approved these changes

View changes

src/Symfony/Component/HttpClient/CHANGELOG.md Outdated Show resolved Hide resolved

carsonbot added Status: Reviewed and removed Status: Needs Review labels


          [HttpClient] Allow yielding Exception from MockResponse's $body to mo…

bbfe9d8

…ck transport errors

fancyweb force-pushed the http-client/mock-response-exception branch from 13d234c to bbfe9d8

fancyweb changed the title ~~[HttpClient] Allow passing an exception directly in the MockResponse body~~ [HttpClient] Allow yielding Exception from MockResponse's $body to mock transport errors

fancyweb merged commit 0f03f94 into symfony:6.1

9 checks passed

fancyweb mentioned this pull request

[HttpClient] Allow yielding Exception from MockResponse's $body to moc… symfony/symfony-docs#16306

Open

fancyweb deleted the http-client/mock-response-exception branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment