Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpClient] fix checking for unset property on PHP <= 7.1.4 #45585

Merged
merged 1 commit into from Feb 28, 2022
Merged

[HttpClient] fix checking for unset property on PHP <= 7.1.4 #45585

merged 1 commit into from Feb 28, 2022

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Feb 28, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

As spotted by the CI and confirmed here: https://3v4l.org/2Xv3N

@carsonbot carsonbot added this to the 4.4 milestone Feb 28, 2022
derrabus
derrabus approved these changes Feb 28, 2022
View changes
Copy link
Member

@derrabus derrabus left a comment

🤯

Let's not merge this up to 5.4 though.

@nicolas-grekas nicolas-grekas merged commit f432349 into symfony:4.4 Feb 28, 2022
7 of 10 checks passed
@nicolas-grekas nicolas-grekas deleted the hc-isset branch Mar 3, 2022
@fabpot fabpot mentioned this pull request Mar 5, 2022
Merged
@fabpot fabpot mentioned this pull request Mar 5, 2022
Merged
@fabpot fabpot mentioned this pull request Mar 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus

Assignees
No one assigned
Labels
Bug HttpClient Status: Reviewed
Projects
None yet
Milestone
4.4
Linked issues

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolas-grekas @derrabus @carsonbot