Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove protractor support #3060

Merged
merged 2 commits into from Oct 7, 2021
Merged

remove protractor support #3060

merged 2 commits into from Oct 7, 2021

Conversation

PeterNgTr
Copy link
Collaborator

@PeterNgTr PeterNgTr commented Oct 5, 2021

Motivation/Description of the PR

Checklist:

  • Documentation has been added (Run npm run docs)

Arhell
Arhell reviewed Oct 6, 2021
View changes
Copy link
Member

@Arhell Arhell left a comment

cc @DavertMik

@Arhell Arhell requested a review from DavertMik Oct 6, 2021
@DavertMik
Copy link
Contributor

@DavertMik DavertMik commented Oct 6, 2021

I absolutely agree on this but please keep Protractor.js file ther. We can't break compatibility until next major release.
Let's remove Protractor from docs, from tests and from other mentions but it should still be working but with deprecation message

@PeterNgTr
Copy link
Collaborator Author

@PeterNgTr PeterNgTr commented Oct 7, 2021

@DavertMik updated the PR.

@DavertMik DavertMik merged commit 6113326 into 3.x Oct 7, 2021
8 checks passed
@DavertMik DavertMik deleted the remove-protractor-ref branch Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell

@DavertMik DavertMik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PeterNgTr @DavertMik @Arhell