Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-92611: Add details on replacements for cgi utility funcs #92792

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CAM-Gerlach
Copy link
Member

@CAM-Gerlach CAM-Gerlach commented May 13, 2022

Per @brettcannon 's suggestions on the Discourse thread, discussed in #92611 and as a followup to PR #92612 , this PR add additional specific per-function replacement information for the utility functions in the cgi module deprecated by PEP 594 (PEP-594).

@brettcannon , should this be backported (without the deprecated-removed , which I would update it accordingly and re-add in my other PR adding that to the others for 3.11+), or just go in 3.11+?

@CAM-Gerlach CAM-Gerlach requested a review from ethanfurman as a code owner May 13, 2022
@bedevere-bot bedevere-bot added docs awaiting review labels May 13, 2022
@CAM-Gerlach CAM-Gerlach requested a review from brettcannon May 13, 2022
@CAM-Gerlach CAM-Gerlach marked this pull request as draft May 14, 2022
@CAM-Gerlach
Copy link
Member Author

@CAM-Gerlach CAM-Gerlach commented May 14, 2022

(The PR is ready for review; I've just marked it as a draft pending the resolution of the question above)


For example, with :class:`email.message.EmailMessage`::

from email.message import EmailMessage
Copy link
Contributor

@slateny slateny May 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be three spaces instead of four?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants