bpo-41524: fix pointer bug in PyOS_mystr{n}icmp #21845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing implementations of PyOS_mystrnicmp and PyOS_mystricmp can increment pointers beyond the end of a string. This commit fixes those cases by moving the mutation out of the condition.
serhiy-storchaka
reviewed
Aug 12, 2020
|
@wmeehan cc @serhiy-storchaka |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Aug 27, 2020
* bpo-41524: fix pointer bug in PyOS_mystr{n}icmp
The existing implementations of PyOS_mystrnicmp and PyOS_mystricmp
can increment pointers beyond the end of a string.
This commit fixes those cases by moving the mutation out of the condition.
* 📜 🤖 Added by blurb_it.
* Address comments
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 97eaf2b)
Co-authored-by: wmeehan <wmeehan@users.noreply.github.com>
|
GH-21978 is a backport of this pull request to the 3.9 branch. |
|
GH-21979 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Aug 27, 2020
* bpo-41524: fix pointer bug in PyOS_mystr{n}icmp
The existing implementations of PyOS_mystrnicmp and PyOS_mystricmp
can increment pointers beyond the end of a string.
This commit fixes those cases by moving the mutation out of the condition.
* 📜 🤖 Added by blurb_it.
* Address comments
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 97eaf2b)
Co-authored-by: wmeehan <wmeehan@users.noreply.github.com>
|
corona10
pushed a commit
that referenced
this issue
Aug 30, 2020
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Aug 30, 2020
* bpo-41524: fix pointer bug in PyOS_mystr{n}icmp
The existing implementations of PyOS_mystrnicmp and PyOS_mystricmp
can increment pointers beyond the end of a string.
This commit fixes those cases by moving the mutation out of the condition.
* 📜 🤖 Added by blurb_it.
* Address comments
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 97eaf2b)
Co-authored-by: wmeehan <wmeehan@users.noreply.github.com>
|
GH-22016 is a backport of this pull request to the 3.8 branch. |
corona10
pushed a commit
that referenced
this issue
Aug 30, 2020
xzy3
pushed a commit
to xzy3/cpython
that referenced
this issue
Oct 18, 2020
* bpo-41524: fix pointer bug in PyOS_mystr{n}icmp
The existing implementations of PyOS_mystrnicmp and PyOS_mystricmp
can increment pointers beyond the end of a string.
This commit fixes those cases by moving the mutation out of the condition.
* 📜 🤖 Added by blurb_it.
* Address comments
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
tekknolagi
pushed a commit
to facebookexperimental/skybison
that referenced
this issue
Aug 26, 2021
Summary: Copy changes from python/cpython#21845 Based on Facebook D23081898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The existing implementations of PyOS_mystrnicmp and PyOS_mystricmp
can increment pointers beyond the end of a string.
This fixes those cases by moving the mutation out of the condition.
https://bugs.python.org/issue41524