Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Do not auto close tracking issue if tests pass #23155

Merged
merged 2 commits into from Apr 20, 2022
Merged

CI Do not auto close tracking issue if tests pass #23155

merged 2 commits into from Apr 20, 2022

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Apr 18, 2022 •
edited

Reference Issues/PRs

Related to #23151

What does this implement/fix? Explain your changes.

Now that the scheduled tests uses different random seeds, the test may fail for one seed and pass for another one. This PR updates the issue tracker script:

  1. To not auto close if all tests start to pass when --auto-close false is passed in
  2. Leaves a comment instead of updating the original body. If a previous run failed because of a random seed and a current run failed because of another reason, I think we want to preserve all information.

@thomasjpfan thomasjpfan changed the title CI: Do not auto close tracking issue if tests pass CI Do not auto close tracking issue if tests pass Apr 18, 2022
jeremiedbb
jeremiedbb approved these changes Apr 19, 2022
View changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Seems reasonable

@lesteve
Copy link
Member

@lesteve lesteve commented Apr 20, 2022

LGTM, merging this one!

@lesteve lesteve merged commit 19efe3a into scikit-learn:main Apr 20, 2022
35 checks passed
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this issue Apr 29, 2022
@thomasjpfan @jjerphan
CI Do not auto close tracking issue if tests pass (scikit-learn#23155)
969f175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiedbb jeremiedbb

Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thomasjpfan @lesteve @jeremiedbb