Skip to content

DataFlow - SummarizedCallable refactor #9210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 20, 2022
Merged

DataFlow - SummarizedCallable refactor #9210

merged 7 commits into from
May 20, 2022

Conversation

michaelnebel
Copy link
Contributor

Avoid duplicate implementations of SummarizedCallable.

@michaelnebel
Copy link
Contributor Author

@hvitved:
DCA investigation.
C#: Looks good. All workflows executed and no performance regression.
Ruby: Looks good. All workflows executed and no performance regression.
Java: Unsure. All workflows except for apache-geode executed (query execution failure). Not sure, if this is a general flakiness issue with that project.

@michaelnebel
Copy link
Contributor Author

@hvitved: DCA investigation. C#: Looks good. All workflows executed and no performance regression. Ruby: Looks good. All workflows executed and no performance regression. Java: Unsure. All workflows except for apache-geode executed (query execution failure). Not sure, if this is a general flakiness issue with that project.

Looks like the apache geode is a flaky project.
Workflow also fails on other PRs (eg this one: #9134).
So we should probably accept the result.
The other java projects did not exhibit any performance regressions.

Setting ready for review.

@michaelnebel michaelnebel marked this pull request as ready for review May 20, 2022 06:58
@michaelnebel michaelnebel requested review from a team as code owners May 20, 2022 06:58
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label May 20, 2022
@aschackmull
Copy link
Contributor

apache-geode

This project currently has a known performance problem.

@hvitved
Copy link
Contributor

hvitved commented May 20, 2022

We can ignore the failing Integration tests, it is unrelated to this PR.

@michaelnebel
Copy link
Contributor Author

We can ignore the failing Integration tests, it is unrelated to this PR.

Excellent!

@michaelnebel michaelnebel merged commit 20af134 into github:main May 20, 2022
@michaelnebel michaelnebel deleted the dataflow/summarizedcallablerefactor branch May 20, 2022 07:49
owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 9, 2022
@owen-mc
Go: Refactor SummarizedCallable.
00ee5b3 
 Equivalent of github#9210
owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 9, 2022
@owen-mc
Go: Refactor SummarizedCallable.
e0beb9a 
 Equivalent of github#9210
owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 17, 2022
@owen-mc
Go: Refactor SummarizedCallable.
282699e 
 Equivalent of github#9210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
C# DataFlow Library Java no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelnebel @aschackmull @hvitved @owen-mc