Swift: Extract semantics and accessor kinds #9274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
force-pushed
the
swift-extract-semantics-and-accessor-kinds
branch
2 times, most recently
from
6bdbcc8 to
2d3fbc1
Compare
MathiasVP
force-pushed
the
swift-extract-semantics-and-accessor-kinds
branch
from
2d3fbc1 to
a065907
Compare
AlexDenisov
reviewed
May 24, 2022
| | expressions.swift:137:3:137:7 | SubscriptExpr | OrdinarySemantics | | ||
| | expressions.swift:138:10:138:10 | DeclRefExpr | OrdinarySemantics | | ||
| | expressions.swift:138:10:138:17 | SubscriptExpr | OrdinarySemantics | | ||
| | file://:0:0:0:0 | DeclRefExpr | OrdinarySemantics | |
There was a problem hiding this comment.
I assume these are coming from the stdlib. We learned that the stdlib is different depending on the OS, so the tests become platform-dependent.
I'd suggest we filter out these entries to make the tests deterministic no matter if we run them on Linux or macOS.
There was a problem hiding this comment.
Ah, right. I'll filter those out. Thanks!
There was a problem hiding this comment.
Fixed in 21641eb.
AlexDenisov
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for an upcoming PR on CFG for property accesses for Swift.
The terminology is borrowed directly from the Swift AST: https://github.com/apple/swift/blob/main/include/swift/AST/Expr.h#L111
I suggest commit-by-commit reviewing: