Kotlin: Add taint step for String.valueOf(Editable) #9319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
previously approved these changes
May 25, 2022
| sink(t.toString()); // $ hasTaintFlow | ||
|
|
||
| val t2 : Any? = source() | ||
| sink(t2.toString()); // $ MISSING: hasTaintFlow |
There was a problem hiding this comment.
t2's type is Object because of the Any? declaration. So the taint step works for Editable? but not for Any?.
This is also causing other issues, e.g. toString's declaring type is Any in both cases, which interferes with our Method::override logic.
There was a problem hiding this comment.
I believe that's consistent with the Java extractor -- if the receiver type doesn't supply an override then MethodAccess.getMethod() points to the inherited method.
Kotlin inlines expr.toString() as String.valueOf(expr) when expr is nullable
atorralba
force-pushed
the
atorralba/add-editable-valueof-step
branch
from
3d6cfcf to
78fcdd2
Compare
|
Tests are now green after #9405. |
smowton
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kotlin inlines
expr.toString()asString.valueOf(expr)whenexpris nullable.This PR extends #8872 by adding a taint step to handle the above when
expris anEditable.