C++: Improve cpp/linux-kernel-no-check-before-unsafe-put-user #9340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://web.archive.org/web/20250522181257im_/https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+47
to
+49
| /** | ||
| * Macros used to check the value (barriers). | ||
| */ |
Check warning
Code scanning / CodeQL
Class QLDoc style.
MathiasVP
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve
cpp/linux-kernel-no-check-before-unsafe-put-userinexperimental. Inspired by #8739 (which was closed) and the tests I developed for that in #8800 . Further improvements (in particular to the way dataflow is used) are definitely possible, but the goal of this PR is just to get specific knowledge out of my head and into the query.In the first commit I define the sources properly, rather than coming from any parameter. In the second commit I adjust the query and test to be closer to reality.