cypress-io / code-coverage

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: print coverage counters in the reporter #74

Open

bahmutov wants to merge 1 commit into master from print-coverage-counters

Contributor

bahmutov commented Sep 10, 2019

To quickly see the coverage after each test

I think it looks kind of nice, here is TodoMVC


          feat: print coverage counters in the reporter

6937d54

bahmutov requested a review from flotwig

flotwig requested changes

  
            return null

            // count current code coverage

            const counters = {

              s: 0,

flotwig Sep 10, 2019
Member

Instead of s, f, b, could statements, functions, branches be used instead? The short names are kinda obscure

bahmutov Sep 10, 2019
Author Contributor

good point, I will keep the one letter properties, since they match the coverage object properties, but will add comments

  
              return

            }

            cy.task('combineCoverage', coverage).then(response => {

              cy.log(`**${response.covered.s}**/**${response.total.s}** statements`)

flotwig Sep 10, 2019
Member

A test that this cy.log works as expected with the correct output would be nice to have, like in submit_spec: https://github.com/cypress-io/cypress/blob/876fe5bbd890164e2bc901f5376cb69d0aaad583/packages/driver/test/cypress/integration/commands/actions/submit_spec.coffee#L168-L172

bahmutov Sep 10, 2019 •

edited

Author Contributor

good observation about logs test, I might start creating test subfolders with test projects. It will be hard to test everything since most of the stuff happens after each or after all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.