stubtest: add error summary, other output nits #12855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- error summary - fix issue where module is saved as stub - handle loading modules that output or raise - output messages instead of tracebacks - add some more tests Also: - move plural_s from messages to util - use plural_s in summary functions
KotlinIsland
force-pushed
the
fix_stubtest
branch
from
b6e7a41
to
4af6a67
Compare
This comment has been minimized.
This comment has been minimized.
hauntsaninja
force-pushed
the
fix_stubtest
branch
from
c54a86b
to
8a87d68
Compare
hauntsaninja
approved these changes
May 28, 2022
There was a problem hiding this comment.
Thanks! I fixed some bugs this introduced related to allowlists and simplified some functionality I don't think is needed. The change to only look at pyi files is good, but should be its own PR (I copied the changes over to #12889). In general, it's good practice to separate behaviour changes like that from cosmetic changes.
hauntsaninja
changed the title
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
KotlinIsland
commented
May 28, 2022
suppres "Nothing to do?!"
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
BaseExceptionAlso:
Test Plan
I added some tests
resolves #12547