gh-92412: Clarifying the documentation on library/syslog #92587
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Every change to Python requires a NEWS entry. Please, add it using the blurb_it Web app or the blurb command-line tool. |
|
Every change to Python requires a NEWS entry. Please, add it using the blurb_it Web app or the blurb command-line tool. |
rhettinger
approved these changes
May 9, 2022
Clarifying the "Changed in version 3.2" paragraph for syslog.openlog as the wording could confuse people about *ident* being a mandatory argument with a default value.
Gaasmann
changed the title
|
@rhettinger Thank you for approving my first pull request :-) |
|
Hello @rhettinger, the PR is ready to be merged. Let me know if there is anything I need to do, this is pretty new to me :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Clarifying the "Changed in version 3.2" paragraph for syslog.openlog as
the wording could confuse people about ident being a mandatory argument
with a default value.