BLD: Build shared c dependencies as a library #47081
Conversation
| @@ -16,5 +16,4 @@ runs: | |||
| python -m pip install -e . --no-build-isolation --no-use-pep517 --no-index | |||
| shell: bash -el {0} | |||
| env: | |||
| # Cannot use parallel compilation on Windows, see https://github.com/pandas-dev/pandas/issues/30873 | |||
| N_JOBS: ${{ runner.os == 'Windows' && 1 || 2 }} | |||
| N_JOBS: 4 | |||
There was a problem hiding this comment.
Might still be worth aligning this with the number of core on the GH hosted runners (2 Window/Linux, 3 MacOS): https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources=
|
Does this affect build size or speed or inlining or ...? |
|
I like this PR, and want to try it out, but my laptop where I do 8-core builds on Windows that always fails is out of commission for a week or so. Once I get that back, I will give it a try and let you know the outcome. |
setup.py
Outdated
| ], | ||
| "include_dirs": [ | ||
| "pandas/_libs/tslibs/src/datetime", | ||
| sysconfig.get_path("include"), |
There was a problem hiding this comment.
Do we need these get_path("include") calls? I think the compiler should handle that natively
There was a problem hiding this comment.
For some reason, the compiler was not able to find Python.h without this.
…into c-shared-library
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Does anyone else want to test this? I can only test with -j4 on my old 2-core i3.