ENH: plot.scatter passes errorbar specific keyword arguments to ax.er… #46954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeitlin11
reviewed
May 7, 2022
doc/source/whatsnew/v1.5.0.rst
Outdated
| @@ -687,6 +687,7 @@ Plotting | |||
| - Bug in :meth:`DataFrame.boxplot` that prevented specifying ``vert=False`` (:issue:`36918`) | |||
| - Bug in :meth:`DataFrame.plot.scatter` that prevented specifying ``norm`` (:issue:`45809`) | |||
| - The function :meth:`DataFrame.plot.scatter` now accepts ``color`` as an alias for ``c`` and ``size`` as an alias for ``s`` for consistency to other plotting functions (:issue:`44670`) | |||
| - The function :meth:`DataFrame.plot.scatter` now passes errorbar keywords to ax.errorbar (:issue:`46952`) | |||
There was a problem hiding this comment.
Can we make this more user-facing than mentioning ax.errorbar - perhaps that it now accepts matplotlib errorbar keywords to allow customizating the axis errorbar
mroeschke
requested changes
May 25, 2022
| @@ -1089,6 +1089,32 @@ def _make_plot(self): | |||
| plot_colorbar = self.colormap or c_is_column | |||
| cb = self.kwds.pop("colorbar", is_numeric_dtype(c_values) and plot_colorbar) | |||
|
|
|||
| # move matplotlib.errorbar specific keywords that are not accepted by | |||
| # ax.scatter to an err_kwds dict for use in the call to ax.errorbar | |||
| ebarkeys = { | |||
There was a problem hiding this comment.
I don't think hardcoding this is a robust approach as it may be brittle to API changes for matplotlb.errorbar.
Is there a way for this to be validate directly by matplotlib.errorbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
…rorbar() (#46952)
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.