REGR: setitem writing into RangeIndex instead of creating a copy #47143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
May 27, 2022
| @@ -531,7 +531,7 @@ def sanitize_array( | |||
| dtype = dtype.numpy_dtype | |||
|
|
|||
| # extract ndarray or ExtensionArray, ensure we have no PandasArray | |||
| data = extract_array(data, extract_numpy=True) | |||
| data = extract_array(data, extract_numpy=True, extract_range=True) | |||
There was a problem hiding this comment.
I think this is the correct place to handle RangeIndexes, but this leaves us in the same position with other array types, like dask arrays, hence the copy below
phofl
reviewed
May 27, 2022
| @@ -611,6 +611,8 @@ def sanitize_array( | |||
| if hasattr(data, "__array__"): | |||
| # e.g. dask array GH#38645 | |||
| data = np.asarray(data) | |||
| if copy: | |||
There was a problem hiding this comment.
Is there an efficient way to check if asarray already made a copy?
simonjayhawkins
reviewed
May 27, 2022
Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
simonjayhawkins
added
Indexing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.