Support calling compile command from when cwd is a source checkout
#207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pyperformance compile` command currently fails when the current directory is a source checkout, since the installation of pyperformance in the benchmark venv is slightly broken, and the detection of running from a source checkout is slightly broken. This is true whether using `python -m pyperformance` or `python ./dev.py` methods. - To detect whether performance is being imported from an "installation" rather than the source directory, it imports toml and then sees if there is a `pyperformance` package sitting alongside it. This (perhaps) worked in the past when `toml` was a module, but it's currently a package, so we need to go up two levels of directories. - `pyperformance` is installed in the benchmark venvs with `pip install .`, but `pip install -e .` actually installs in editable/developer mode, as described elsewhere.
|
@kumaraditya303: Would you mind giving this a review? |
Sure, I was waiting for someone to allow CI as I don't have the permission. I'll test it locally now. |
|
@mdboom: Do you an example of config file with which you tested it ? |
|
Closing this -- it's kind of a corner case in practice and I haven't hit it again since. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pyperformance compilecommand currently fails when the current directoryis a source checkout, since the installation of pyperformance in the benchmark
venv is slightly broken, and the detection of running from a source checkout is
slightly broken. This is true whether using
python -m pyperformanceorpython ./dev.pymethods.To detect whether performance is being imported from an "installation" rather
than the source directory, it imports toml and then sees if there is a
pyperformancepackage sitting alongside it. This (perhaps) worked in the pastwhen
tomlwas a module, but it's currently a package, so we need to go up twolevels of directories.
pyperformanceis installed in the benchmark venvs withpip install ., butpip install -e .actually installs in editable/developer mode, as describedelsewhere.
I struggled to write a short-running unit test for this -- there are a lot of moving parts that need to align to reproduce this. However, there is an existing test that currently fails on main, but passes with these changes. It's marked as
@SLOW, so I suspect it hasn't run on CI in quite some time. I'd appreciate any thoughts about whether that's sufficient...