changes: add note saying the locale based strcasecmp has been replaced #18390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulidale
added
approval: review pending
beldmit
reviewed
May 24, 2022
| @@ -30,7 +30,10 @@ breaking changes, and mappings for the large list of deprecated functions. | |||
|
|
|||
| ### Changes between 3.0.3 and 3.0.4 [xx XXX xxxx] | |||
|
|
|||
| * none yet | |||
| * Case insensitive string comparison no longer uses locales. It has instead | |||
There was a problem hiding this comment.
I think it's okay either way but there is no mentioned of locale objects in the earlier changes entry.
t8m
approved these changes
May 24, 2022
t8m
added
triaged: documentation
slontis
approved these changes
May 27, 2022
|
Merged, thanks for the feedback. |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 1, 2022
Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from #18390)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed reversion of changes for the locale free compare, 3.0 version. Master in #18389.