Fix CFN Events create rule without targets #6061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschubert
requested changes
May 16, 2022
pinzon
force-pushed
the
fix-cfn-events-rule-wout-targets
branch
3 times, most recently
from
9de47df to
f91c276
Compare
pinzon
force-pushed
the
fix-cfn-events-rule-wout-targets
branch
from
f91c276 to
45e948d
Compare
dominikschubert
approved these changes
May 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #6033, where is shown that LocalStack CFN throws an error when trying to create a Rule that was defined without Targets. When testing against AWS, shows that it should work without problems.
Changes: