gh-93353: Fix importlib.resources._tempfile() finalizer #93377
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the importlib.resources.as_file() context manager to remove the temporary file if destroyed late during Python finalization: keep a local reference to the os.remove() function. Patch by Victor Stinner.
|
I convert the PR to a draft, it lacks an unit test. I plan to write a test.support helper function to make sure that an object is destroyed as late as possible during Python finalization. The first implementation would use os.register_at_fork(). But I also would like to change when os.register_at_fork() is cleared. IMO it's cleared too late, causing bugs like #93353 which are very hard to debug since Python cannot log errors anymore. Too many things are cleared/finalized to be able to log an error at this point. The point of the helper is to find a new hook if os.register_at_fork() is cleared earlier ;-) Also, I'm writing in a train and I'm close to the train station, so I will finish later :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix the importlib.resources.as_file() context manager to remove the
temporary file if destroyed late during Python finalization: keep a
local reference to the os.remove() function. Patch by Victor Stinner.