Add tests which verify EventBridge rules behavior #6124
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
![github-actions[bot]](https://web.archive.org/web/20250604050823im_/https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
|
I have read the CLA Document and I hereby sign the CLA |
| logs_client.delete_log_stream( | ||
| logGroupName=log_group_name, logStreamName=log_stream["logStreamName"] | ||
| ) | ||
| logs_client.delete_log_group(logGroupName=log_group_name) |
There was a problem hiding this comment.
This might actually be a good time to clean up the test_events.py file and bring it up to date in terms of testing patterns in a separate PR if you're interested 👍
There was a problem hiding this comment.
small remark to the cleanup function (don't need to fix this): any exception in here will cause all cleanups afterwards to be skipped. This is mostly a problem when dealing with tests against AWS (e.g. when debugging). You'll be creating a lot of orphaned resources this way.
This PR adds three tests which verify correct behavior of EventBridge rules:
create ruleconstraints align with those of aws