Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check for stdarg.h (HAVE_STDARG_PROTOTYPES) in configure.ac #93207

Closed
kumaraditya303 opened this issue May 25, 2022 · 3 comments · Fixed by #93215
Closed

Remove check for stdarg.h (HAVE_STDARG_PROTOTYPES) in configure.ac #93207

kumaraditya303 opened this issue May 25, 2022 · 3 comments · Fixed by #93215
Assignees
@kumaraditya303
Labels
3.12 build type-bug

Comments

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented May 25, 2022 •
edited

CPython checks for stdarg.h as HAVE_STDARG_PROTOTYPES 1 at some places 2 but not at other places 3. Either this check should be repeated at every call site or should be removed all together, most compilers supports this nowadays (should be verified with buildbots).

cc @vstinner @tiran @erlend-aasland

Footnotes

  1. cpython/configure.ac

    Line 5026 in 16a7e4a

    AC_CACHE_CHECK([for variable length prototypes and stdarg.h], [ac_cv_stdarg_prototypes], [
    ↩

  2. cpython/Modules/_asynciomodule.c

    Line 2646 in 16a7e4a

    #ifdef HAVE_STDARG_PROTOTYPES
    ↩

  3. cpython/Objects/call.c

    Line 557 in 16a7e4a

    va_start(va, format);
    ↩
@kumaraditya303 kumaraditya303 added the type-bug label May 25, 2022
@erlend-aasland erlend-aasland added the build label May 25, 2022
@vstinner
Copy link
Member

@vstinner vstinner commented May 25, 2022

Do you want to propose a PR for that?

@kumaraditya303 kumaraditya303 self-assigned this May 25, 2022
@kumaraditya303 kumaraditya303 mentioned this issue May 25, 2022
Merged
@kumaraditya303
Copy link
Contributor Author

@kumaraditya303 kumaraditya303 commented May 25, 2022

Created PR #93215

kumaraditya303 added a commit to kumaraditya303/cpython that referenced this issue May 27, 2022
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into pythong…
f0ef047 
…h-93207
vstinner pushed a commit that referenced this issue May 27, 2022
@kumaraditya303
GH-93207: Remove HAVE_STDARG_PROTOTYPES configure check for stdarg.h (#…
cb04a09 
…93215)
@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 2, 2022

[...] most compilers supports this nowadays

As pointed out in cython/cython#4820, this may change in the future:

https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2975.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumaraditya303 kumaraditya303

Labels
3.12 build type-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-93207: Remove configure check for stdarg.h (HAVE_STDARG_PROTOTYPES) kumaraditya303/cpython
3 participants
@vstinner @erlend-aasland @kumaraditya303