gh-43414: os.get_terminal_size() should use file descriptors in Windows #93203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
eryksun
reviewed
May 25, 2022
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
It would be nice to add a test in @unittest.skipUnless(sys.platform == 'win32', 'Windows specific test')
def test_windows_fd(self):
# gh-87580: support arbitrary file descriptors
try:
conout = open('conout$', 'w')
except OSError:
self.skipTest('failed to open conout$')
with conout:
size = os.get_terminal_size(conout.fileno())
self.assertGreaterEqual(size.columns, 0)
self.assertGreaterEqual(size.lines, 0) |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
zooba
reviewed
Jul 28, 2022
Misc/NEWS.d/next/Windows/2022-05-28-19-36-13.gh-issue-43414.NGMJ3g.rst
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Modified
os.get_terminal_size()to use_get_osfhandle(fd)instead of using hardcoded process standard handles in Windows.Fixes 43414