gh-93244: Py_PRINT_RAW was incorrectly spelled as Py_Print_RAW. #93245
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
This doesn't need a news entry, please delete it. A |
|
Happy to! I didn't think that it did! The bot asked, so I obliged!
…On Thu, May 26, 2022 at 9:34 AM Adam Turner ***@***.***> wrote:
This doesn't need a news entry, please delete it.
A
—
Reply to this email directly, view it on GitHub
<#93245 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCP2CU6KZNXSQ2M6GDUACDVL54X3ANCNFSM5W7V2QNA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
hawkinsw
force-pushed
the
py_print_raw_typo
branch
from
df18d47 to
ca5fc3e
Compare
|
Updated! Thanks @AA-Turner ! |
It does say most! Non-user facing changes (e.g. comments in source code) or minor documentation changes generally don't need a NEWS entry, although sometimes it's a judgement call. Thanks for updating! A |
Include/abstract.h
Outdated
|
|
||
| (What should be said about Py_Print_RAW?). */ | ||
| (What should be said about Py_PRINT_RAW?). */ |
There was a problem hiding this comment.
If you modify this comment, please answer the question. By default (flags=0), PyObject_Print() calls PyObject_Repr(), whereas Py_PRINT_RAW calls PyObject_Str(). See the doc:
https://docs.python.org/dev/c-api/object.html#c.PyObject_Print
Py_PRINT_RAW was incorrectly spelled as Py_Print_RAW.
hawkinsw
force-pushed
the
py_print_raw_typo
branch
from
ca5fc3e to
c8495ba
Compare
|
@hawkinsw please don't force push, it makes review harder. All commits to CPython are squash-merged. Perhaps "stringified" or "converted to string" instead of ' "rendered" '? I imagine you were trying to avoid using the term string as the paragraph later discusses A |
Sorry! I didn't realize that they were squashed! I was just trying to keep the history clean!
Great suggestion! Standby for an update.
|
|
@AA-Turner Took your comment under advisement and I hope that I did the right thing! |
Taking suggestion. Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
Took your suggestion! Thanks! |
|
Merged, thanks. |
Py_PRINT_RAW was incorrectly spelled as Py_Print_RAW in Include/Abstract.h