Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] 📝 Make sure the phrase "constant-time compare" actually appears in the docs (GH-93396) #93399

Merged
merged 1 commit into from Jun 10, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 1, 2022

This is purely for SEO as this is the actual generic name for this kind of method and it currently does not appear in a Google search for "python constant time compare". Not creating an issue or setting this up for backports as its trivial (I think) and not a functional change.
(cherry picked from commit 8241a69)

Co-authored-by: Noah Kantrowitz noah@coderanger.net

…e docs (pythonGH-93396)

This is purely for SEO as this is the actual generic name for this kind of method and it currently does not appear in a Google search for "python constant time compare". Not creating an issue or setting this up for backports as its trivial (I think) and not a functional change.
(cherry picked from commit 8241a69)

Co-authored-by: Noah Kantrowitz <noah@coderanger.net>
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented Jun 1, 2022

@coderanger: Status check is done, and it's a failure ❄1�7 .

1 similar comment
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented Jun 1, 2022

@coderanger: Status check is done, and it's a failure ❄1�7 .

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented Jun 1, 2022

@coderanger: Status check is done, and it's a failure ❄1�7 .

@bedevere-bot bedevere-bot added docs awaiting review labels Jun 1, 2022
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented Jun 1, 2022

Status check is done, and it's a success ✄1�7 .

@ambv ambv merged commit cc6149f into python:3.11 Jun 10, 2022
14 checks passed
@miss-islington miss-islington deleted the backport-8241a69-3.11 branch Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants