Skip to content

docs: fix missing closing div in http page #46258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: fix missing closing div in http page #46258

wants to merge 1 commit into from

Conversation

sniperwolf
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Alert div is not closing in http doc page:

image

Issue Number: N/A

What is the new behavior?

Closing div in http doc page.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from dylhunn June 4, 2022 22:12
@dylhunn dylhunn added aio: preview target: patch This PR is targeted for the next patch release labels Jun 5, 2022
@mary-poppins
Copy link

You can preview 680dafd at https://pr46258-680dafd.ngbuilds.io/.

@dylhunn dylhunn added the action: merge The PR is ready for merge by the caretaker label Jun 5, 2022
@alxhub
Copy link
Member

alxhub commented Jun 6, 2022

This PR was merged into the repository by commit 6724e43.

alxhub pushed a commit that referenced this pull request Jun 6, 2022
@sniperwolf @alxhub
docs: fix missing closing div in http page (#46258)
e7ff714 
PR Close #46258
@alxhub alxhub closed this in 6724e43 Jun 6, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dylhunn dylhunn dylhunn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sniperwolf @mary-poppins @alxhub @dylhunn