Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] gh-91162: Fix substitution of unpacked tuples in generic aliases (GH-92335) #92484

Open
wants to merge 1 commit into
base: 3.11
Choose a base branch
from

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 8, 2022

(cherry picked from commit 9d25db9)

Co-authored-by: Serhiy Storchaka storchaka@gmail.com

pythonGH-92335)

(cherry picked from commit 9d25db9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 8, 2022

@serhiy-storchaka: Status check is done, and it's a success .

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 8, 2022

@serhiy-storchaka: Status check is done, and it's a success .

1 similar comment
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 8, 2022

@serhiy-storchaka: Status check is done, and it's a success .

@Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented May 8, 2022

Huh, the strings are tied to runtime state, which is tied to the ABI, so the ABI test is now failing. Should we regenerate the ABI data file or just change the code to lookup the C const char *(which will be slightly slower)?

CC @pablogsal

@pablogsal
Copy link
Member

@pablogsal pablogsal commented May 8, 2022

Huh, the strings are tied to runtime state, which is tied to the ABI, so the ABI test is now failing. Should we regenerate the ABI data file or just change the code to look up the C const char *(which will be slightly slower)?

In this case, you can regenerate the ABI, but this will not be possible in the RC state

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 8, 2022

@serhiy-storchaka: Status check is done, and it's a failure .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants