Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docstring for win_getpass to reflect code changes #24967

Merged
merged 1 commit into from May 4, 2021

Conversation

jugmac00
Copy link
Contributor

@jugmac00 jugmac00 commented Mar 22, 2021

The code was updated in
0ec88b3
but the docstring was left untouched.

=> updated the docstring to reflect the code changes

Automerge-Triggered-By: GH:tiran

The code was updated in
python@0ec88b3
but the docstring was left untouched.

=> updated the docstring to reflect the code changes
Copy link

@obestwalter obestwalter left a comment

Keeping comments in sync with the code - community edition.

tiran
tiran approved these changes May 3, 2021
@tiran tiran added needs backport to 3.9 skip issue skip news 🤖 automerge PR will be merged once it's been approved and all CI passed labels May 3, 2021
@miss-islington
Copy link
Contributor

miss-islington commented May 3, 2021

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@tiran tiran added 🤖 automerge PR will be merged once it's been approved and all CI passed and removed 🤖 automerge PR will be merged once it's been approved and all CI passed labels May 4, 2021
@miss-islington miss-islington merged commit d4222ea into python:main May 4, 2021
10 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented May 4, 2021

Thanks @jugmac00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 4, 2021
…24967)

The code was updated in
python@0ec88b3
but the docstring was left untouched.

=> updated the docstring to reflect the code changes
(cherry picked from commit d4222ea)

Co-authored-by: Jürgen Gmach <juergen.gmach@googlemail.com>
@bedevere-bot
Copy link

bedevere-bot commented May 4, 2021

GH-25878 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Contributor

miss-islington commented May 4, 2021

Thanks @jugmac00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 4, 2021
…24967)

The code was updated in
python@0ec88b3
but the docstring was left untouched.

=> updated the docstring to reflect the code changes
(cherry picked from commit d4222ea)

Co-authored-by: Jürgen Gmach <juergen.gmach@googlemail.com>
@bedevere-bot
Copy link

bedevere-bot commented May 4, 2021

GH-25879 is a backport of this pull request to the 3.10 branch.

@jugmac00 jugmac00 deleted the fix-docstring branch May 4, 2021
miss-islington added a commit that referenced this pull request May 4, 2021
The code was updated in
0ec88b3
but the docstring was left untouched.

=> updated the docstring to reflect the code changes
(cherry picked from commit d4222ea)

Co-authored-by: Jürgen Gmach <juergen.gmach@googlemail.com>
miss-islington added a commit that referenced this pull request May 4, 2021
The code was updated in
0ec88b3
but the docstring was left untouched.

=> updated the docstring to reflect the code changes
(cherry picked from commit d4222ea)

Co-authored-by: Jürgen Gmach <juergen.gmach@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants