Skip to content

gh-90839: Forward gzip.compress() compresslevel to zlib #31215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2022
Merged

gh-90839: Forward gzip.compress() compresslevel to zlib #31215

merged 1 commit into from
Apr 12, 2022

Conversation

iii-i
Copy link
Contributor

@iii-i iii-i commented Feb 8, 2022 •
edited by bedevere-bot
Loading

gzip.compress() does not forward compresslevel to zlib.compress() - no matter what the user specifies, the actual compression level ends up being 6. This started with ea23e78. Fix by adding the missing kwarg to zlib.compress() call.

https://bugs.python.org/issue46681

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@iii-i

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@merwok merwok requested a review from ambv February 12, 2022 12:25
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. If the CLA is not signed within 14 days, it will be closed. See also https://devguide.python.org/pullrequest/#licensing

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 15, 2022
@iii-i
Copy link
Contributor Author

iii-i commented Apr 6, 2022

Ping.

@corona10 corona10 added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Apr 12, 2022
@corona10 corona10 self-requested a review April 12, 2022 13:20
@corona10 corona10 removed needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Apr 12, 2022
@corona10 corona10 changed the title bpo-46681: Forward gzip.compress() compresslevel to zlib gh-90839: Forward gzip.compress() compresslevel to zlib Apr 12, 2022
corona10
corona10 approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the catch

@corona10 corona10 self-assigned this Apr 12, 2022
@corona10 corona10 merged commit 943ca5e into python:main Apr 12, 2022
@iii-i iii-i mannequin mentioned this pull request Apr 10, 2022
Closed
@JelleZijlstra JelleZijlstra mentioned this pull request May 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@ambv ambv Awaiting requested review from ambv

Assignees

@corona10 corona10

Labels
stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iii-i @the-knights-who-say-ni @corona10 @bedevere-bot