Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90879: Fix missing parameter for put_nowait() #91514

Merged
merged 5 commits into from Apr 14, 2022
Merged

gh-90879: Fix missing parameter for put_nowait() #91514

merged 5 commits into from Apr 14, 2022

Conversation

slateny
Copy link
Contributor

@slateny slateny commented Apr 14, 2022

@slateny slateny requested a review from rhettinger as a code owner Apr 14, 2022
@bedevere-bot bedevere-bot added awaiting review docs labels Apr 14, 2022
corona10
corona10 requested changes Apr 14, 2022
View changes
Copy link
Member

@corona10 corona10 left a comment

I would like to suggest changing into more explicit explanation :)

Lib/queue.py Outdated Show resolved Hide resolved
Doc/library/queue.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 14, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

slateny and others added 3 commits Apr 14, 2022
@slateny @corona10
Update Lib/queue.py
066d59e 
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@slateny @corona10
Update Doc/library/queue.rst
3691685 
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@slateny
Update for consistency
5847131
@slateny
Copy link
Contributor Author

@slateny slateny commented Apr 14, 2022

I have made the requested changes; please review again

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 14, 2022

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from corona10 Apr 14, 2022
@slateny
Copy link
Contributor Author

@slateny slateny commented Apr 14, 2022

(also updated this, which didn't have the parameter)

corona10
corona10 approved these changes Apr 14, 2022
View changes
Copy link
Member

@corona10 corona10 left a comment

lgtm

@corona10 corona10 merged commit 0fc3517 into python:main Apr 14, 2022
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 14, 2022

Thanks @slateny for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 14, 2022

GH-91527 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Apr 14, 2022
@slateny @miss-islington
pythongh-90879: Fix missing parameter for put_nowait() (pythonGH-91514)
c8b5605 
(cherry picked from commit 0fc3517)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 14, 2022

Thanks @slateny for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 14, 2022

GH-91528 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this issue Apr 14, 2022
@miss-islington @slateny
gh-90879: Fix missing parameter for put_nowait() (GH-91514)
52ce75f 
(cherry picked from commit 0fc3517)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
miss-islington added a commit that referenced this issue Apr 14, 2022
@miss-islington @slateny
gh-90879: Fix missing parameter for put_nowait() (GH-91514)
f3f5d4b 
(cherry picked from commit 0fc3517)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

@rhettinger rhettinger

Assignees
No one assigned
Labels
docs skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@slateny @bedevere-bot @miss-islington @corona10 @kumaraditya303