gh-90473: Decrease recursion limit and skip tests on WASI (GH-92803) #92803
Conversation
tiran
commented
May 14, 2022
- Reduce recursion limit to 750. WASI has limited call stack.
- Mark tests that require mmap, os.pipe, or fail on musl libc.
tiran
force-pushed
the
gh-90473-wasi-rec-test
branch
4 times, most recently
from
0d3f889
to
24ff31d
Compare
tiran
requested review from
berkerpeksag,
pganssle,
abalkin,
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan,
warsaw and
vsajip
as code owners
mostly LGTM
What's the plan for un-skipping all those tests? Some of them seem like they should be fixable right now but I expect some may not ever work.
We need to revise the skips whenever we update to a new version of WASI SDK. The standard evolves in small incremental steps. Each version adds a few new features. |
LGTM (There were a few things I'm not familiar with that I'll trust you on.
I noted a couple cases where it seems like we should be able to tweak tests instead of skipping them. However, I'll leave their resolution up to your judgement.
Lib/test/test_syntax.py
Outdated
| @@ -2117,6 +2117,7 @@ def test_syntax_error_on_deeply_nested_blocks(self): | |||
| self._check_error(source, "too many statically nested blocks") | |||
|
|
|||
| @support.cpython_only | |||
| @unittest.skipIf(support.is_wasi, "Exhausts WASI call stack") | |||
There was a problem hiding this comment.
Is there some way we could tweak the test to get the same coverage?
There was a problem hiding this comment.
I was able to make the test pass with a smaller parser MAXSTACK value on WASI.
CC @pablogsal
Reduce recursion limit to 750. WASI has limited call stack. Mark tests that require mmap, os.pipe, or fail on musl libc.
tiran
changed the title
|
Thanks @tiran for the PR |
|
GH-92952 is a backport of this pull request to the 3.11 branch. |
…onGH-92803) (cherry picked from commit 137fd3d88aa46669f5717734e823f4c594ab2843) Co-authored-by: Christian Heimes <christian@python.org>
