-
Notifications
You must be signed in to change notification settings - Fork 951
ci: build Linux binary in Alpine container #2826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Interesting error on the macOS build: |
I think the macOS error is just a flaky test, this change seems unlikely to cause this error. |
Ugh I'm hitting this error again: #1063 (comment) |
Here is a fix: |
This makes it easier to move the TinyGo compiler between Linux versions because it doesn't depend on any system libraries anymore. For example, binaries should be able to run on old Linux versions and on distributions without glibc (such as Alpine Linux).
Trying again with the patch, hopefully it passes this time. |
This PR seems to be ready! |
This is fantastic work. We can now look at distributing an Alpine based image as well as the Debian based one. |
It's even better: the binary will run on practically any Linux system out there because there are no dependencies on the host system. So no separate binaries needed. Or do you mean Docker images? Yes, we could do that, or switch to Alpine entirely because they are usually smaller. |
Yes, I meant switch to Alpine based Docker containers for everything. |
This makes it easier to move the TinyGo compiler between Linux versions because it doesn't depend on any system libraries anymore. For example, binaries should be able to run on old Linux versions and on distributions without glibc (such as Alpine Linux).
This doesn't directly fix #2815 but a similar fix for ARM would have avoided the #2815 issue.