fixes ./... syntax in tinygo test
#2885
Conversation
|
Could you link to (and if needed, file) a tinygo issue describing the problem you're trying to solve? Thanks! |
1 similar comment
|
Could you link to (and if needed, file) a tinygo issue describing the problem you're trying to solve? Thanks! |
| @@ -89,7 +90,7 @@ type Package struct { | |||
| // Load loads the given package with all dependencies (including the runtime | |||
| // package). Call .Parse() afterwards to parse all Go files (including CGo | |||
| // processing, if necessary). | |||
| func Load(config *compileopts.Config, inputPkgs []string, clangHeaders string, typeChecker types.Config) (*Program, error) { | |||
| func Load(config *compileopts.Config, inputPkg string, clangHeaders string, typeChecker types.Config) (*Program, error) { | |||
There was a problem hiding this comment.
I turned this into a single package for a few reasons:
- It is used for single package only everywhere.
- It is easier to deal with a single package.
- This error is only looking at one package and it is actually thought of a single package
jcchavezs
changed the title
|
@dkegel-fastly I linked the problem in the description. Do you want me to create a github issue? |
jcchavezs
changed the title
tinygo test
|
Yeah, at least for now, it would help if you had a github issue / github PR pair for each individual problem you are solving. (I used to try to do multiple problems in one PR, but life is better with just one problem per PR, linked to a clear issue with reproducer.) |
jcchavezs
changed the title
tinygo test./... syntax in tinygo test
|
Did a cherry-pick of this commit to try the smoke test cc @dkegel-fastly |
|
It is green :D @dkegel-fastly |
|
I would suggest cleaning up the commit history in this branch a bit... make it looks like you got it right the first try. No need to show dirty laundry! |
|
I can do that but I wonder if we keep this as it is because there are some
learnings in the mistakes and do the clean up of messaging by squashing the
merge?
|
|
Hello, @jcchavezs and @dkegel-fastly Having atomic commits and a clean history is part of our merge/rebase criteria. If you want to preserve additional info, I would suggest keep that in a branch on a fork. Hopefully that helps clarify. Thank you! |
|
Thanks for the clarification. I will do so.
|
…g#2892 tests/testing/recurse has two directories with tests; "make smoketest" now does "tinygo test ./..." in that directory and fails if it does not run both directories' tests.
|
I cleaned up the commits. |
|
Can we get this merged please? |
|
Give it a couple days :-) |
|
Shall we? |
|
I'll review this today. |
|
Thank you very much for working on this @jcchavezs now merging. |
Adds proper support for
./...syntax which was broken or maybe never intended to be supported and it only somehow worked because we usego listunderneath. Allowing to use./...is actually a good experience ingo test.For example, running the tinygo@0.23.0 like:
whereas
./tests/testing/threedotshas two packages.Closes #2892