gh-93103: Parser uses PyConfig.parser_debug instead of Py_DebugFlag #93106
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Flag Replace deprecated Py_DebugFlag with PyConfig.parser_debug in the parser.
pablogsal
approved these changes
May 23, 2022
| @@ -32,7 +32,7 @@ | |||
| #include "pegen.h" | |||
| #if defined(Py_DEBUG) && defined(Py_BUILD_CORE) | |||
| # define D(x) if (Py_DebugFlag) x; | |||
| # define D(x) if (_Py_GetConfig()->parser_debug) { x; } | |||
There was a problem hiding this comment.
I wonder if this makes the debug run slower due to the function call (is everywhere)
Could you do a quick check please?
There was a problem hiding this comment.
This change only affects the debug build. I don't know how to measure the parser performance. Any suggestion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Replace deprecated Py_DebugFlag with PyConfig.parser_debug in the
parser.