New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40514: Drop EXPERIMENTAL_ISOLATED_SUBINTERPRETERS #93185
bpo-40514: Drop EXPERIMENTAL_ISOLATED_SUBINTERPRETERS #93185
Conversation
I expected that this conditional code would become the default quickly, but I got way more technical issues than expected. I managed to fix many issues: https://vstinner.github.io/isolate-subinterpreters.html But there are still multiple big issues like static types, singletons or getting the thread state ("tstate") from a thread local storage (TLS). Hopefully, immortal objects may fix static types and singletons, and it seems possible to fix #84702 (tstate). This experiment was useful to discover all issues and have a better plan to fully implement the feature ("per-interpreter GIL"). |
If we decide to remove this flag, I would like to recommend adding the entry for What's NEWS
.
Although this flag was not intended to expose to the public user, this flag was spread out to users who have interests in the multi-core sub interpreter project.
example: https://stackoverflow.com/a/65995393
This is also broken on main branch and 3.11 as it won't even compile with this option. See #90988 |
Yes, please. |
@pablogsal, would it be okay to backport this to 3.11? (It already doesn't work on 3.11 currently.) |
Yep, I'm ok backporting this |
Thanks @ericsnowcurrently for the PR |
Sorry, @ericsnowcurrently, I could not cleanly backport this to |
…-93185) This was added for bpo-40514 (pythongh-84694) to test out a per-interpreter GIL. However, it has since proven unnecessary to keep the experiment in the repo. (It can be done as a branch in a fork like normal.) So here we are removing: * the configure option * the macro * the code enabled by the macro
… (GH-93306) (cherry picked from commit caa279d) This was added for bpo-40514 (gh-84694) to test out a per-interpreter GIL. However, it has since proven unnecessary to keep the experiment in the repo. (It can be done as a branch in a fork like normal.) So here we are removing: * the configure option * the macro * the code enabled by the macro Automerge-Triggered-By: GH:ericsnowcurrently
This was added for bpo-40514 (gh-84694) to test out a per-interpreter GIL. However, it has since proven unnecessary to keep the experiment in the repo. (It can be done as a branch in a fork like normal.) So here we are removing: