Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-93548: add exemple of SASL PLAIN authentication in documentation #93549

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JulienFS
Copy link

@JulienFS JulienFS commented Jun 6, 2022

No description provided.

@JulienFS JulienFS requested a review from as a code owner Jun 6, 2022
@cpython-cla-bot
Copy link

@cpython-cla-bot cpython-cla-bot bot commented Jun 6, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 6, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@JulienFS
Copy link
Author

@JulienFS JulienFS commented Jun 6, 2022

It seems that the specifications explicitly forbid the use of ENABLE before auth :

The ENABLE command is only valid in the authenticated state, before any mailbox is selected.

Maybe the login phase should handle UTF8 natively though :

Characters are 8-bit UTF-8 (of which 7-bit US-ASCII is a subset), unless otherwise specified.

EDIT: defaulting to UTF-8 is an IMAP4Rev2 thing. But it looks like some servers advertising rev1 are supporting utf-8.

@JulienFS
Copy link
Author

@JulienFS JulienFS commented Jun 6, 2022

OK I feel silly, it looks like everybody is using AUTHENTICATE to bypass the UTF-8 limit and I was not aware of this. I'll revert my changes and update the documentation with a plain auth example.

@AA-Turner AA-Turner added type-bug expert-email labels Jun 6, 2022
@JulienFS JulienFS changed the title gh-93548: allow ENABLE command in NONAUTH state in imaplib gh-93548: add exemple of SASL PLAIN authentication in documentation Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review expert-email type-bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants