Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The compatibility problems start with expat 2.4.4, not just 2.4.5 #93018

Closed
mcepl opened this issue May 20, 2022 · 3 comments · Fixed by #93900
Closed

The compatibility problems start with expat 2.4.4, not just 2.4.5 #93018

mcepl opened this issue May 20, 2022 · 3 comments · Fixed by #93900
Labels
expert-XML type-bug An unexpected behavior, bug, or error

Comments

@mcepl
Copy link
Contributor

mcepl commented May 20, 2022

This

cpython/Lib/test/test_minidom.py

Line 1152 in f20a6a5

if pyexpat.version_info >= (2, 4, 5):

and this

cpython/Lib/test/test_minidom.py

Line 1620 in f20a6a5

if pyexpat.version_info >= (2, 4, 5):

is wrong. Change of raised errors happened already in 2.4.4 not only in 2.4.5.
@mcepl mcepl mentioned this issue May 20, 2022
Closed
@ronaldoussoren ronaldoussoren added type-bug An unexpected behavior, bug, or error expert-XML labels May 23, 2022
@corona10
Copy link
Member

corona10 commented Jun 1, 2022

@hartwork Would you like to take look at this issue?

@hartwork
Copy link
Contributor

hartwork commented Jun 1, 2022

@hartwork Would you like to take look at this issue?

@corona10 had a quick look now, commented at #93022 (review) . Thanks for bringing this to my attention. 👍

@corona10
Copy link
Member

corona10 commented Jun 3, 2022

closing the issue: #93022 (comment)

Thank you @hartwork

@corona10 corona10 closed this as completed Jun 3, 2022
@mcepl mcepl mentioned this issue Jun 16, 2022
Merged
mcepl added a commit to mcepl/cpython that referenced this issue Jun 16, 2022
@mcepl
pythongh-93018: Fix for the compatibility problems with expat
8b3441f 
This is another take on python#93022, fixes python#93018.

1. I believe it is inappropriate to assert on the error message for the
   external API. Error messages are not part of the provided contract
   with its users.
2. I don't think we are really care what exact exception is thrown, it
   is much more important that non-well-formed XML is discovered.
3. Changing tests based on the version of library seems as a code smell
   to me, but that's personal opinion.
corona10 pushed a commit that referenced this issue Dec 7, 2022
@mcepl
gh-93018: Fix for the compatibility problems with expat (gh-93900)
7031275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
expert-XML type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
4 participants
@mcepl @ronaldoussoren @hartwork @corona10