Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add an empty line as secondary prompt #93424

Merged
merged 1 commit into from Jul 22, 2022
Merged

Conversation

vinzid
Copy link
Contributor

@vinzid vinzid commented Jun 1, 2022

There should be an empty line before the secondary prompt return to primary prompt.
If this empty line is absent, the code to copy will arise error since the next line will still in secondary prompt.

Before change
Code to show:
Before change (code to show)
Code to copy:
Before change (code to copy)
Run the code:
Before change (run the code)

After change
Code to show:
After change (code to show)
Code to copy:
After change (code to copy)
Run the code:
After change (run the code)

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jun 1, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

bedevere-bot commented Jun 1, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

slateny
slateny approved these changes Jun 8, 2022
@kumaraditya303 kumaraditya303 requested a review from zware Jul 22, 2022
zware
zware approved these changes Jul 22, 2022
@zware zware merged commit 34d11f1 into python:main Jul 22, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jul 22, 2022

Thanks @vinzid for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 22, 2022

Sorry @vinzid and @zware, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 34d11f1b0c0e1936a37581e0fb0daec637afca47 3.11

@bedevere-bot
Copy link

bedevere-bot commented Jul 22, 2022

GH-95147 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2022
(cherry picked from commit 34d11f1)

Co-authored-by: Chenwei Xiao <chanvinxiao@163.com>
@miss-islington
Copy link
Contributor

miss-islington commented Jul 22, 2022

Thanks @vinzid for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒🤖

@bedevere-bot
Copy link

bedevere-bot commented Jul 22, 2022

GH-95148 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2022
(cherry picked from commit 34d11f1)

Co-authored-by: Chenwei Xiao <chanvinxiao@163.com>
miss-islington added a commit that referenced this pull request Jul 22, 2022
(cherry picked from commit 34d11f1)

Co-authored-by: Chenwei Xiao <chanvinxiao@163.com>
miss-islington added a commit that referenced this pull request Jul 22, 2022
(cherry picked from commit 34d11f1)

Co-authored-by: Chenwei Xiao <chanvinxiao@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants