[FrameworkBundle] Disable Serializer data collect by default #46625
+61
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtarld
approved these changes
Jun 9, 2022
|
Do we want to enable this by default for new projects via a recipe? Can you please send a PR doing so if yes? |
nicolas-grekas
approved these changes
Jun 9, 2022
|
Thank you @chalasr. |
|
Here is the recipe PR symfony/recipes#1095 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The serializer data collector introduced in 6.1. causes a BC break for some (see fixed ticket).
This PR adds a
framework.profiler.collect_serializer_dataoption defaulting tofalse, allowing people to fix their code before activating it.Next steps:
ObjectNormalizerautowiring alias on 6.2 and fix the docs accordinglyBuild failures unrelated.