[Mime] Check that the path is a file in the DataPart::fromPath #46535
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkania
force-pushed
the
bugfix/check-that-the-path-is-a-file
branch
from
f367c56
to
315e347
Compare
nicolas-grekas
reviewed
Jun 1, 2022
nicolas-grekas
approved these changes
Jun 1, 2022
chalasr
approved these changes
Jun 1, 2022
|
Thank you @wkania. |
chalasr
force-pushed
the
bugfix/check-that-the-path-is-a-file
branch
from
4e152ed
to
a807523
Compare
Merged
|
Is there a reason why this hasn't been released for 4.4 and 5.4 yet? I am running on 5.4 and this is likely causing a bug in one of our projects. Best regards. |
|
We publish patch releases regularly (once a month). Since 4.4.42 has been released 27 days ago I guess there will be a new release soon. |
This was referenced Jun 26, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The directory can also be readable. Fix to the PR.
Found it while working on another fix related to this method.