bpo-29524: Add Objects/call.c file #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move all functions to call objects in a new Objects/call.c file. * Rename fast_function() to _PyFunction_FastCallKeywords(). * Copy null_error() from Objects/abstract.c * Inline type_error() in call.c to not have to copy it, it was only called once. * Export _PyEval_EvalCodeWithName() since it is now called from call.c.
methane
requested changes
Feb 11, 2017
| inlines the most primitive frame setup code from | ||
| PyEval_EvalCodeEx(), which vastly reduces the checks that must be | ||
| done before evaluating the frame. | ||
| */ |
There was a problem hiding this comment.
This comment block should be moved to function_code_fastcall().
|
Oh in fact it was a deliberate choice to remove the comment. Python 3.7 now
has a wide range of "fast call" functions which are designed for best
performance. Do you think that it's worth it to keep the comment?
|
methane
approved these changes
Feb 12, 2017
I just checked all code is moved as-is.
I agree the comment block is not so important.
|
Thank you for the review.
|
|
Follow-up at #7909 |
paulmon
added a commit
to paulmon/cpython
that referenced
this issue
Jan 10, 2019
Windows arm32 - fix failing tests or skip
ethanhs
added a commit
to ethanhs/cpython
that referenced
this issue
Mar 16, 2020
tiran
added a commit
to tiran/cpython
that referenced
this issue
Nov 18, 2020
Direct leak of 57 byte(s) in 1 object(s) allocated from:
#0 0x7fa6397cc667 in __interceptor_malloc (/lib64/libasan.so.6+0xb0667)
#1 0x777579 in PyUnicode_New Objects/unicodeobject.c:1459
#2 0x86aa4e in unicode_decode_utf8 Objects/unicodeobject.c:5129
#3 0x8b6050 in PyUnicode_DecodeUTF8Stateful Objects/unicodeobject.c:5259
#4 0x8b6050 in PyUnicode_FromString Objects/unicodeobject.c:2311
#5 0x8b6050 in PyUnicode_InternFromString Objects/unicodeobject.c:15788
#6 0x8f1e0b in create_filter Python/_warnings.c:67
#7 0x8f1e0b in init_filters Python/_warnings.c:95
#8 0x8f1e0b in _PyWarnings_InitState Python/_warnings.c:123
python#9 0xa52178 in pycore_init_types Python/pylifecycle.c:704
python#10 0xa52178 in pycore_interp_init Python/pylifecycle.c:760
python#11 0xa5eab1 in pyinit_config Python/pylifecycle.c:807
python#12 0xa5eab1 in pyinit_core Python/pylifecycle.c:970
python#13 0xa60037 in Py_InitializeFromConfig Python/pylifecycle.c:1155
python#14 0x47a842 in pymain_init Modules/main.c:66
python#15 0x4802a2 in pymain_main Modules/main.c:698
python#16 0x4802a2 in Py_BytesMain Modules/main.c:731
python#17 0x7fa638a5b041 in __libc_start_main (/lib64/libc.so.6+0x27041)
Signed-off-by: Christian Heimes <christian@python.org>
isidentical
referenced
this issue
in isidentical/cpython
Jun 29, 2021
* Handle lines with multi-byte unicode characters properly * Use Py_XDECREF instead of Py_DECREF Co-authored-by: Batuhan Taskaya <isidentical@gmail.com> Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
http://bugs.python.org/issue29524