Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7] bpo-42103: Improve validation of Plist files. (GH-22882) #23117

Merged
merged 1 commit into from Nov 10, 2020
Merged

[3.7] bpo-42103: Improve validation of Plist files. (GH-22882) #23117

merged 1 commit into from Nov 10, 2020

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 2, 2020 •
edited by bedevere-bot
Loading

  • Prevent some possible DoS attacks via providing invalid Plist files
    with extremely large number of objects or collection sizes.
  • Raise InvalidFileException for too large bytes and string size instead of returning garbage.
  • Raise InvalidFileException instead of ValueError for specific invalid datetime (NaN).
  • Raise InvalidFileException instead of TypeError for non-hashable dict keys.
  • Add more tests for invalid Plist files..
    (cherry picked from commit 34637a0)

Co-authored-by: Serhiy Storchaka storchaka@gmail.com

https://bugs.python.org/issue42103
@serhiy-storchaka
[3.7] bpo-42103: Improve validation of Plist files. (pythonGH-22882)
c45cd34 
* Prevent some possible DoS attacks via providing invalid Plist files
  with extremely large number of objects or collection sizes.
* Raise InvalidFileException for too large bytes and string size instead of returning garbage.
* Raise InvalidFileException instead of ValueError for specific invalid datetime (NaN).
* Raise InvalidFileException instead of TypeError for non-hashable dict keys.
* Add more tests for invalid Plist files..
(cherry picked from commit 34637a0)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Nov 2, 2020
Merged
@ned-deily ned-deily merged commit 225e365 into python:3.7 Nov 10, 2020
11 checks passed
Loading
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 10, 2020

@ned-deily: Please replace # with GH- in the commit message next time. Thanks!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed type-bugfix type-security
Projects
None yet
Milestone
No milestone
4 participants
@serhiy-storchaka @bedevere-bot @ned-deily @the-knights-who-say-ni