Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-821: Add/rename new types #880

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

za
Copy link
Contributor

@za za commented Jun 4, 2022

WIP: still need to add the description.

Refer to this merged PR:
https://github.com/python/bedevere/pull/419/files

Closes #821

WIP: still need to add the description.

Refer to this merged PR:
https://github.com/python/bedevere/pull/419/files

GH issue:
python#821
@ezio-melotti ezio-melotti self-assigned this Jun 4, 2022
@za za marked this pull request as ready for review Jun 6, 2022
@za
Copy link
Contributor Author

@za za commented Jun 6, 2022

Hi @ezio-melotti I've added the description using https://github.com/python/cpython/labels as the reference. Please check.

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jun 6, 2022

@za, FYI, if you include the phrase "Closes #821" or "Fixes #821" in your PR description, then issue #821 will be automatically closed when this PR is merged. That will mean that you won't have to ping a maintainer to manually close an issue after the PR has been merged :)

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

@za
Copy link
Contributor Author

@za za commented Jun 6, 2022

Hi @AlexWaygood Thanks! I've updated the PR description :-)

Copy link
Member

@ezio-melotti ezio-melotti left a comment

Note that the type labels have changed, they all have a type-* prefix and don't include docs and tests anymore. The whole section needs a major overhaul, which I'm planning to do as soon as I have some time, but in the meanwhile I think it's ok to just update this table with the existing type-* labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants