Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44947: Refine the syntax error for trailing commas in import statements #27814

Merged
merged 1 commit into from Aug 18, 2021
Merged

bpo-44947: Refine the syntax error for trailing commas in import statements #27814

merged 1 commit into from Aug 18, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Aug 18, 2021 •
edited by bedevere-bot

@pablogsal pablogsal requested a review from lysnikolaou as a code owner Aug 18, 2021
@ambv ambv merged commit b2f68b1 into python:main Aug 18, 2021
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 18, 2021

Thanks @pablogsal for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Aug 18, 2021

Sorry, @pablogsal and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b2f68b190035540872072ac1d2349e7745e85596 3.9

@bedevere-bot
Copy link

bedevere-bot commented Aug 18, 2021

GH-27816 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 18, 2021
@pablogsal @miss-islington
bpo-44947: Refine the syntax error for trailing commas in import stat…
6bcaf77 
…ements (pythonGH-27814)

(cherry picked from commit b2f68b1)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Aug 18, 2021
@miss-islington @pablogsal
bpo-44947: Refine the syntax error for trailing commas in import stat…
846a10f 
…ements (GH-27814)

(cherry picked from commit b2f68b1)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
ambv pushed a commit to ambv/cpython that referenced this pull request Aug 18, 2021
@pablogsal @ambv
[3.9] bpo-44947: Refine the syntax error for trailing commas in impor…
c16c0d6 
…t statements (pythonGH-27814).

(cherry picked from commit b2f68b1)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 18, 2021

GH-27817 is a backport of this pull request to the 3.9 branch.

ambv added a commit that referenced this pull request Aug 18, 2021
@ambv @pablogsal
[3.9] bpo-44947: Refine the syntax error for trailing commas in impor…
4e4d35d 
…t statements (GH-27814) (GH-27817)

(cherry picked from commit b2f68b1)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou

Assignees

@ambv ambv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pablogsal @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni