Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_poplib replace asyncore #74699

Open
grzgrzgrz3 mannequin opened this issue May 30, 2017 · 5 comments
Open

test_poplib replace asyncore #74699

grzgrzgrz3 mannequin opened this issue May 30, 2017 · 5 comments
Labels
3.11 expert-email tests

Comments

@grzgrzgrz3
Copy link
Mannequin

@grzgrzgrz3 grzgrzgrz3 mannequin commented May 30, 2017

BPO 30514
Nosy @vstinner, @grzgrzgrz3
PRs
  • #1864
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2017-05-30.17:24:00.054>
labels = ['tests', '3.11']
title = 'test_poplib replace asyncore'
updated_at = <Date 2021-11-16.10:15:25.763>
user = 'https://github.com/grzgrzgrz3'

    bugs.python.org fields:

    activity = <Date 2021-11-16.10:15:25.763>
actor = 'iritkatriel'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2017-05-30.17:24:00.054>
creator = 'grzgrzgrz3'
dependencies = []
files = []
hgrepos = []
issue_num = 30514
keywords = []
message_count = 2.0
messages = ['294770', '406378']
nosy_count = 2.0
nosy_names = ['vstinner', 'grzgrzgrz3']
pr_nums = ['1864']
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue30514'
versions = ['Python 3.11']
    @grzgrzgrz3
    Copy link
    Mannequin Author

    @grzgrzgrz3 grzgrzgrz3 mannequin commented May 30, 2017

    sub-issue of bpo-28533

    @grzgrzgrz3 grzgrzgrz3 mannequin added 3.7 tests labels May 30, 2017
    @vstinner
    Copy link
    Member

    @vstinner vstinner commented Nov 15, 2021

    I removed asyncore in bpo-28533:

    New changeset 9bf2cbc by Victor Stinner in branch 'main':
    bpo-28533: Remove asyncore, asynchat, smtpd modules (GH-29521)
    9bf2cbc

    But I kept a private copy as test.support._asyncore for the few tests which still use it (asyncore, asynchat and/or smtpd).

    @iritkatriel iritkatriel added 3.11 and removed 3.7 labels Nov 16, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @hugovk hugovk mentioned this issue Apr 11, 2022
    Open
    @hugovk
    Copy link
    Member

    @hugovk hugovk commented Apr 11, 2022

    Update: asyncore, asynchat, smtpd are still in 3.11 but set for removal in 3.12.

    See:

    @JelleZijlstra JelleZijlstra mentioned this issue May 10, 2022
    Open
    @AA-Turner
    Copy link
    Member

    @AA-Turner AA-Turner commented Jun 7, 2022

    @arhadthedev does this duplicate #93243?

    A

    @arhadthedev
    Copy link
    Contributor

    @arhadthedev arhadthedev commented Jun 7, 2022

    @AA-Turner It seems so, but this issue already has a working PR. If @grzgrzgrz3 resolves the conflict there, I'd prefer to wait until it gets merged and to either close my PR or turn it into a rescurrection of gh-29521.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 expert-email tests
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    6 participants
    @vstinner @iritkatriel @hugovk @serhiy-storchaka @arhadthedev @AA-Turner