bpo-38085: Fix throw exception in __init__subclass__ causes wrong isinstance() a… #30112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd issubclass() results in subclasses of abc.ABCMeta.
|
see my comments on the issue. imo this is solving the symptom of the problem, but not the root problem, which is that a broken class appears in its base classes |
|
This PR is stale because it has been open for 30 days with no activity. |
MaxwellDupre
approved these changes
Feb 7, 2022
Looks good to me. All tests passed for me:
./python -m test -v test_abc
Ran 72 tests in 0.019s
OK
== Tests result: SUCCESS ==
1 test OK.
Total duration: 96 ms
Tests result: SUCCESS
cpython on abc-init-subclass-exception [$] via
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
…nd issubclass() results in subclasses of abc.ABCMeta.
https://bugs.python.org/issue38085