Skip to content

ensure bytecode::Instruction never grows more than 8bytes #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2022
Merged

ensure bytecode::Instruction never grows more than 8bytes #3724

merged 1 commit into from
May 26, 2022

Conversation

youknowone
Copy link
Member

No description provided.

@youknowone youknowone requested a review from coolreader18 May 24, 2022 02:06
@coolreader18
Copy link
Member

Not that I'm against the dependency but you can also do the same thing by just const _: () = assert!(size_of::<Instruction>() == 8);

@youknowone
Copy link
Member Author

Do you want to replace it not to use the crate? It is already used by core. It will not affect build time or binary size that much.

coolreader18
coolreader18 approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah, it's fine either way actually

@coolreader18 coolreader18 merged commit 2efe9e2 into RustPython:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowone @coolreader18