Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check and report PEP 11 support tier in configure #93491

Closed
tiran opened this issue Jun 4, 2022 · 0 comments · Fixed by #93492
Closed

Check and report PEP 11 support tier in configure #93491

tiran opened this issue Jun 4, 2022 · 0 comments · Fixed by #93492
Assignees
@brettcannon
Labels
3.11 3.12 build type-feature

Comments

@tiran
Copy link
Member

@tiran tiran commented Jun 4, 2022 •
edited

Feature or enhancement

PEP 11 now defines support tiers based on CPU arch, platform, libc, and compiler. I propose to check the support level in configure and report it to the user. It is trivial to check the platform with a case block. The compiler name can be detect by builtin macro names like __clang__.

A message at build time makes support tier more obvious to the user. It might even nudge some vendors to contribute fixes and build bots.

Example:

checking for PEP 11 support tier... x86_64-pc-linux-gnu/gcc has tier 1 (supported)

checking for PEP 11 support tier... wasm32-unknown-emscripten/clang is not supported
...
configure: creating Modules/Setup.local
configure: creating Makefile
configure:

If you want a release build with all stable optimizations active (PGO, etc),
please run ./configure --enable-optimizations

configure:

Platform "wasm32-unknown-emscripten" with compiler "clang" is not supported by
CPython core team, see https://peps.python.org/pep-0011/ for more information.
@tiran tiran added type-feature build 3.11 3.12 labels Jun 4, 2022
tiran added a commit to tiran/cpython that referenced this issue Jun 4, 2022
@tiran
pythongh-93491: Add support tier detection to configure
c59f088
tiran added a commit to tiran/cpython that referenced this issue Jun 4, 2022
@tiran
pythongh-93491: Add support tier detection to configure
5b0583e
tiran added a commit to tiran/cpython that referenced this issue Jun 10, 2022
@tiran
pythongh-93491: Add support tier detection to configure
823b0b2
@erlend-aasland erlend-aasland linked a pull request Jun 10, 2022 that will close this issue
gh-93491: Add support tier detection to configure (GH-93492) #93492
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 10, 2022
@tiran @miss-islington
pythongh-93491: Add support tier detection to configure (pythonGH-93492)
a739db0 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit 3124d9a5aafb64431aa9facd0ae0e12201be77fa)

Co-authored-by: Christian Heimes <christian@python.org>
tiran added a commit that referenced this issue Jun 10, 2022
@tiran @AA-Turner
@zooba @erlend-aasland
gh-93491: Add support tier detection to configure (GH-93492)
3124d9a 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this issue Jun 10, 2022
@miss-islington @tiran
gh-93491: Add support tier detection to configure (GH-93492)
516d90e 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit 3124d9a)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brettcannon brettcannon

Labels
3.11 3.12 build type-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-93491: Add support tier detection to configure (GH-93492) tiran/cpython
2 participants
@brettcannon @tiran